Skip to content

chore(eid-wallet): bump to 1.2.0 - #1168

Merged
Sahil2004 merged 1 commit into
mainfrom
Bekiboo/bump-eid-wallet-1.2.0
Sep 26, 2026
Merged

Sahil2004 merged 1 commit into
mainfrom
Bekiboo/bump-eid-wallet-1.2.0

Conversation

@Bekiboo

@Bekiboo Bekiboo commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Description of change

Bumps the eID wallet from 1.1.1 to 1.2.0 ahead of the release.

Minor rather than patch: six changes have landed since 1.1.1 and five are fixes, but #1145 added Russian and Ukrainian, which is a new user-facing capability and the headline of this release.

The Android versionCode is a hand-maintained counter in tauri.conf.json, not derived from the version string, and Play rejects an upload that does not raise it. It goes to 32, continuing 24, 25, 26, 27, 28, 31.

The version string itself is written in six places — tauri.conf.json, package.json, Cargo.toml, Cargo.lock, and the two generated iOS files, which the last bump (#1141) also updated by hand.

Type of change

  • Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Version strings only, no code paths touched.

Change checklist

  • I have removed any unnecessary logic
  • My code follows the pattern of the application
  • I have signed my commits
  • I have self reviewed my code

Summary by CodeRabbit

  • Release Updates
    • Updated the eID Wallet release version to 1.2.0.
    • Advanced the Android app version number for this release. This update changes release identification only; no new user-facing features or behavior changes are included in the provided summary.

@Bekiboo
Bekiboo requested a review from coodos as a code owner September 25, 2026 15:13
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⛔ Files ignored due to path filters (4)
  • infrastructure/eid-wallet/src-tauri/Cargo.lock is excluded by !**/*.lock
  • infrastructure/eid-wallet/src-tauri/gen/apple/eid-wallet.xcodeproj/project.pbxproj is excluded by !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/eid-wallet_iOS/Info.plist is excluded by !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/project.yml is excluded by !**/gen/**
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a9892764-a8aa-43c8-8365-9bcc93430842

📥 Commits

Reviewing files that changed from the base of the PR and between 8b2a0a3 and 5ec458a.

⛔ Files ignored due to path filters (4)
  • infrastructure/eid-wallet/src-tauri/Cargo.lock is excluded by !**/*.lock
  • infrastructure/eid-wallet/src-tauri/gen/apple/eid-wallet.xcodeproj/project.pbxproj is excluded by !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/eid-wallet_iOS/Info.plist is excluded by !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/project.yml is excluded by !**/gen/**

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 50ca0b18-4974-4005-a304-1ec6b1835803

📥 Commits

Reviewing files that changed from the base of the PR and between e1ad13d and 486cc65.

⛔ Files ignored due to path filters (3)
  • infrastructure/eid-wallet/src-tauri/Cargo.lock is excluded by !**/*.lock
  • infrastructure/eid-wallet/src-tauri/gen/apple/eid-wallet_iOS/Info.plist is excluded by !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/project.yml is excluded by !**/gen/**
📒 Files selected for processing (3)
  • infrastructure/eid-wallet/package.json
  • infrastructure/eid-wallet/src-tauri/Cargo.toml
  • infrastructure/eid-wallet/src-tauri/tauri.conf.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The eID Wallet package and Tauri application versions change from 1.1.1 to 1.2.0. The Android bundle version code changes from 31 to 32.

Changes

eID Wallet version update

Layer / File(s) Summary
Update release version declarations
infrastructure/eid-wallet/package.json, infrastructure/eid-wallet/src-tauri/Cargo.toml, infrastructure/eid-wallet/src-tauri/tauri.conf.json
The package and application versions change to 1.2.0. The Android bundle version code changes from 31 to 32.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 486cc

The release metadata is aligned at 1.2.0, and Android’s version code is set to 32. No concrete release-versioning issue remains that should block merging.

Architecture Summary

Architecture risk: 🔵 Low · up to 486cc

The change affects 1 system.

Changed systems: infrastructure

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — infrastructure (service) was modified; 3 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in infrastructure/eid-wallet/package.json: The package version changes from 1.1.1 to 1.2.0.
  • observed — Modified behavior in infrastructure/eid-wallet/src-tauri/Cargo.toml: The package version changes from 1.1.1 to 1.2.0.
  • observed — Modified behavior in infrastructure/eid-wallet/src-tauri/tauri.conf.json: The configured application version changes from 1.1.1 to 1.2.0.
  • observed — Modified behavior in infrastructure/eid-wallet/src-tauri/tauri.conf.json: The Android bundle versionCode changes from 31 to 32.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the eID wallet to version 1.2.0.
Description check ✅ Passed The description includes the required sections and explains the version bump, Android versionCode change, change type, testing, and checklist status. The Issue Number section is empty, and two checkli…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Bekiboo
Bekiboo force-pushed the Bekiboo/bump-eid-wallet-1.2.0 branch from 7c2ac78 to 486cc65 Compare September 25, 2026 15:17
@Bekiboo Bekiboo self-assigned this Sep 26, 2026
@Bekiboo
Bekiboo force-pushed the Bekiboo/bump-eid-wallet-1.2.0 branch from 486cc65 to 8b2a0a3 Compare September 26, 2026 08:31
Russian and Ukrainian arrived in #1145, so this release is a minor rather than
a patch.

The Android versionCode is a hand-maintained counter, not something derived
from the version, and Play rejects an upload that does not raise it. It goes
to 32, continuing 24, 25, 26, 27, 28, 31.

iOS carries the version in three places that have to agree: project.yml and
Info.plist, and MARKETING_VERSION / CURRENT_PROJECT_VERSION in the Xcode
project, which is the pair Xcode actually builds from.
@Bekiboo
Bekiboo force-pushed the Bekiboo/bump-eid-wallet-1.2.0 branch from 8b2a0a3 to 5ec458a Compare September 26, 2026 08:55
@Sahil2004
Sahil2004 merged commit fac8425 into main Sep 26, 2026
4 checks passed
@Sahil2004
Sahil2004 deleted the Bekiboo/bump-eid-wallet-1.2.0 branch September 26, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants